Read once again after stdin token cancelled #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
stdin-wait
branch
from
12ff9cb to
05772a2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
==========================================
+ Coverage 32.34% 32.40% +0.06%
==========================================
Files 13 13
Lines 1110 1117 +7
Branches 418 420 +2
==========================================
+ Hits 359 362 +3
- Misses 468 471 +3
- Partials 283 284 +1 |
This fixes the first test of `should support inline execution and attach`: https://github.com/kubernetes/kubernetes/blob/7f129f1c9af62cc3cd4f6b754dacdf5932f39d5c/test/e2e/kubectl/kubectl.go#L603-L612 Short lived attach sessions may have some more content to read after they exited, which is now fixed by trying another read after the token has been canceled via the waitpid exit. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
stdin-wait
branch
from
05772a2 to
7c35832
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This fixes the first test of
should support inline execution and attach:https://github.com/kubernetes/kubernetes/blob/7f129f1c9af62cc3cd4f6b754dacdf5932f39d5c/test/e2e/kubectl/kubectl.go#L603-L612
Short lived attach sessions may have some more content to read after they exited, which is now fixed by trying another read after the token has been canceled via the waitpid exit.
Which issue(s) this PR fixes:
Refers to #736
Special notes for your reviewer:
The
--leave-stdin-open=truetests are still failing, but those have to be fixed in another PR:https://github.com/kubernetes/kubernetes/blob/7f129f1c9af62cc3cd4f6b754dacdf5932f39d5c/test/e2e/kubectl/kubectl.go#L614-L648
Does this PR introduce a user-facing change?