Shutdown tracing after runtime #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This makes the overall exporter race a bit more resilient against race conditions. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
tracing-shutdown
branch
from
876f0dd to
e517a45
Compare
|
/retest |
|
Ugh, that label add wasn’t intentional. 🫣 |
|
it's okay, I meant to lgtm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This makes the overall exporter race a bit more resilient against race conditions.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
We still seem to miss the root spans in some cases, but the overall result for a container creation will now look like this, which is promising:
Does this PR introduce a user-facing change?