Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image name different between podman versions after pulling from docker-daemon:// location #10998

Closed
tetchel opened this issue Jul 20, 2021 · 3 comments · Fixed by #10983
Closed

Image name different between podman versions after pulling from docker-daemon:// location #10998

tetchel opened this issue Jul 20, 2021 · 3 comments · Fixed by #10983
Assignees
@vrothberg
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@tetchel
Copy link

tetchel commented Jul 20, 2021 •
edited
Loading

Podman version: 3.2.2

Previously, when pulling an image from the Docker image storage, the image in Podman would then be prefixed with docker.io/library.

eg.
podman pull docker-daemon:myimage
->
podman images has docker.io/library/myimage

But now, the image is prefixed with localhost.

eg.
podman pull docker-daemon:myimage
->
podman images has locahost/myimage

This is a good change, this behaviour makes a lot more sense. But I do not see it in the release notes.

I know this was changed sometime between versions 3.1.2 and 3.2.2 so I am assuming it was changed in the minor release 3.2.0.

But, since we now have to read the podman version to determine how the image will be tagged after pulling, we have to know the exact version that introduced the new behaviour.

Does anyone know in which version of Podman this change was introduced?

re: redhat-actions/push-to-registry#42 (comment)
@rhatdan
Copy link
Member

rhatdan commented Jul 21, 2021

@vrothberg PTAL.

I believe the behavior should end up with an image named.

docker.io/library/myimage

Since this is what it is named in docker.io.

localhost/myimage indicates the image was created locally and does not have a default registry. podman build images have this name.

@vrothberg vrothberg self-assigned this Jul 21, 2021
@vrothberg vrothberg added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Jul 21, 2021
@vrothberg
Copy link
Member

Thanks for reaching out! I'll take a look.

vrothberg added a commit to vrothberg/common that referenced this issue Jul 21, 2021
@vrothberg
libimage: pull: normalize docker-daemon
22d38e0 
Normalize images pulled from the docker-daemon transport to docker.io
and not to localhost.  That preserves previous behavior of Podman.

Also fix a parsing bug in the pull code that was revealed while testing
the changes; parsing errors should be returned if there is a matching
transport without falling through to pulling the input string as an
image from a registry.

Context: containers/podman/issues/10998
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg mentioned this issue Jul 21, 2021
Merged
vrothberg added a commit to vrothberg/common that referenced this issue Jul 21, 2021
@vrothberg
libimage: pull: normalize docker-daemon
fc115ac 
Normalize images pulled from the docker-daemon transport to docker.io
and not to localhost.  That preserves previous behavior of Podman.

Also fix a parsing bug in the pull code that was revealed while testing
the changes; parsing errors should be returned if there is a matching
transport without falling through to pulling the input string as an
image from a registry.

Context: containers/podman/issues/10998
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member

I opened containers/common#685 to fix it.

@vrothberg vrothberg mentioned this issue Jul 22, 2021
Merged
vrothberg added a commit to vrothberg/libpod that referenced this issue Jul 26, 2021
@vrothberg
refine dangling checks
1b6423e 
By proxy by vendoring containers/common. Previously, a "dangling" image
was an untagged image; just a described in the Docker docs. The
definition of dangling has now been refined to an untagged image without
children to be compatible with Docker.

Further update a redundant image-prune test.

Fixes: containers#10998
Fixes: containers#10832
Signed-off-by: Valentin Rothberg <[email protected]>
@tetchel tetchel mentioned this issue Sep 10, 2021
Closed
10 tasks
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refine dangling checks vrothberg/libpod
3 participants
@rhatdan @tetchel @vrothberg