Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with league/flysystem-bundle 3.3.0 #50

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conflict with league/flysystem-bundle 3.3.0 #50

merged 1 commit into from
Oct 31, 2023

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Oct 31, 2023

Version 3.3.0 seems to have a (may be unintentional) BC break in it:

Fatal error: Uncaught ArgumentCountError: Too few arguments to function League\FlysystemBundle\Adapter\AdapterDefinitionFactory::createDefinition(), 2 passed in vendor\contao\contao\core-bundle\src\DependencyInjection\Filesystem\FilesystemConfiguration.php on line 91 and exactly 3 expected in vendor\league\flysystem-bundle\src\Adapter\AdapterDefinitionFactory.php:43

@ausi ausi changed the title Conflict with "league/flysystem-bundle": "3.3.0" Conflict with league/flysystem-bundle 3.3.0 Oct 31, 2023
@ausi ausi merged commit 13977eb into contao:main Oct 31, 2023
@ausi
Copy link
Member

ausi commented Oct 31, 2023

Version 3.3.0 seems to have a (may be unintentional) BC break in it:

Looks like it was intentional, from thephpleague/flysystem-bundle#153 :

I didn't manage any BC because all classes are marked "internal".

@fritzmg fritzmg mentioned this pull request Oct 31, 2023
Closed
@fritzmg fritzmg deleted the patch-4 branch October 31, 2023 16:17
@fritzmg fritzmg mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzmg @ausi