Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Correcting the PublishedBy and UpdatedBy fields to include the sys object. #61

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

VigRoco
Copy link

@VigRoco VigRoco commented Apr 12, 2021

The API returns a Sys object for the publishedBy and updatedBy fields. This PR fixes that issue by restructuring the types.

Correcting the PublishedBy and UpdatedBy fields to include the sys key.
@codecov-io
Copy link

Codecov Report

Merging #61 (fcb3c4a) into master (c2cba1b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   53.70%   53.70%           
=======================================
  Files          13       13           
  Lines         998      998           
=======================================
  Hits          536      536           
  Misses        402      402           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cba1b...fcb3c4a. Read the comment docs.

This adds the environment url param to the publish and get calls.
@codecov-commenter
Copy link

Codecov Report

Merging #61 (d250803) into master (c2cba1b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   53.70%   53.70%           
=======================================
  Files          13       13           
  Lines         998      998           
=======================================
  Hits          536      536           
  Misses        402      402           
  Partials       60       60           
Impacted Files Coverage Δ
entry.go 14.47% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cba1b...d250803. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@c2cba1b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   53.70%           
=========================================
  Files             ?       13           
  Lines             ?      998           
  Branches          ?        0           
=========================================
  Hits              ?      536           
  Misses            ?      402           
  Partials          ?       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cba1b...0edbb3a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants