Fix/do not write errors to file when used as library #1113
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are using this package to migrate our content models. Whenever a runtime error occurs in one of our backends based on Lambda functions, the whole handler errors out because of an unhandled promise rejection caused by the Lambda's filesystem being mounted as readonly and thus not allowing the error files to be written.
Description
In order to fix this issue, the PR adjusts two things:
shouldThrow === true
).Motivation and Context
When used as a library, the error files are probably irrelevant, except for debugging purposes, or might - as in our case - even be harmful, as depending on the runtime environment, no filesystem is available.
Todos
This is rather a proposal than an actual finished implementation, as I do not have the time and knowledge, to build and verify the changes.