Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransformEntriesToType: readme extended, fixed small issue #163

Closed
wants to merge 47 commits into from
Closed

TransformEntriesToType: readme extended, fixed small issue #163

wants to merge 47 commits into from

Conversation

GordonApplepie
Copy link
Contributor

@GordonApplepie GordonApplepie commented Jan 4, 2019

@TimBeyer as requested I extended the README.md. You will find the problem with the fetcher.ts also in this PR. Due to that change it also made sense to remove the method isEntryTransformToType from the intend interface.

The problem is that we need the entries of all content types since we are tryíng to update the parental entries and replace the old linked entries to the newly created ones. The parental entries can be of every possible type in the space.

The following filter prohibits this even when the id collection is empty:

const filter = {
    'sys.contentType.sys.id[in]': ids.join(','),
    'sys.archivedAt[exists]': 'false'
}

@TimBeyer
Copy link
Contributor

TimBeyer commented Jan 4, 2019

Could you separate the PRs so that we have one clean PR branched from master that does the readme change, and then we can fix the ID filter separately.

@GordonApplepie
Copy link
Contributor Author

@TimBeyer yeah. true that was not so clever actually. I also saw that it is fixed already 😃 will close down this PR and create a new one for the readme file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants