Terminate with an error when a migration is aborted #858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
This Pull Request changes the behaviour when you select
N
(No) when the script prompts you whether you want to apply a migration.Previous behaviour:
New behaviour:
terminate
has been configured.I'll leave it to your discretion, but this is likely a breaking change and would require releasing a new major semver version.
Motivation and Context
I'm plugging
contentful-migration
into our CLI-based migration tooling (using umzug), so it's nice if aborting the migration prevents subsequent commands from running. The current behaviour is particularly problematic when using an external migration tool, because it will interpret the run as a success and will therefore consider the migration as applied, even though it hasn't been.A workaround would be to force the script not to prompt, using the
yes
option. I quite like the nice feedback thecontentful-migration
library gives you before applying a change, though, so it would be a shame to lose that. (Especially when testing migrations locally against a test environment.)Screenshots:
Before:
After: