Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace listr with listr2 #982

Merged
merged 1 commit into from
Jan 31, 2022
Merged

feat: replace listr with listr2 #982

merged 1 commit into from
Jan 31, 2022

Conversation

patrickedqvist
Copy link
Contributor

Summary

This PR replaces the listr package (which hasn't received an update since October 2019) with the more maintained listr2

Motivation and Context

Replacing this package hopefully resolves an issue that I've encountered myself when trying to contribute to the contentful-userland/contentful-action where I've updated all the packages to more recent versions.

By updating the packages I've encountered the following problem.

Error: Cannot find any-observable implementation nor global.Observable. 
You must install polyfill or call require("any-observable/register") with your preferred implementation, 
e.g. require("any-observable/register")('rxjs') on application load prior to any require("any-observable").

I've tried to resolve the issue in my fork by following the above recommendations but without any luck. Digging deeper into the issue and found that the problem lies with the listr package used by this project.

@patrickedqvist patrickedqvist changed the title Use listr2 instead of listr feat: replace listr with listr2 Jan 11, 2022
@ruderngespra ruderngespra requested review from a team and ruderngespra January 31, 2022 15:00
@ruderngespra
Copy link
Contributor

Hey @patrickedqvist, sorry this took so long, and thanks for the suggested change which makes a lot of sense to me!

@ruderngespra ruderngespra merged commit c3cb9fe into contentful:master Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jan 31, 2022
@patrickedqvist patrickedqvist deleted the feature/listr2 branch February 1, 2022 21:20
veu added a commit that referenced this pull request Apr 4, 2022
* build(deps-dev): bump eslint-plugin-promise from 5.1.0 to 6.0.0

Bumps [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from 5.1.0 to 6.0.0.
- [Release notes](https://github.com/xjamundx/eslint-plugin-promise/releases)
- [Changelog](https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md)
- [Commits](https://github.com/xjamundx/eslint-plugin-promise/commits)

---
updated-dependencies:
- dependency-name: eslint-plugin-promise
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix(config): Fix missing uuid dependency when using the built package (#984)

* Fix README.md in the editField section

The function description says that the `id` parameter will be used to identify the field to be deleted.

* feat: replace listr with listr2 (#982)

* fix(dependencies): bump ts + contentful-management (#1019)

* build(deps-dev): bump @types/node from 14.14.19 to 17.0.14 (#1020)

* build(deps): bump follow-redirects from 1.14.3 to 1.14.8 (#1022)

* build(deps-dev): bump ts-node from 10.3.0 to 10.5.0 (#1023)

* build(deps-dev): bump source-map-support from 0.5.20 to 0.5.21 (#976)

* build(deps-dev): bump @types/mocha from 9.0.0 to 9.1.0 (#1026)

* feat(options): Expose retryLimit parameter

* chore(lint): Configure prettier

* fix: add retryLimit to RunMigrationConfig type

* build(deps-dev): bump @types/lodash from 4.14.174 to 4.14.179 (#1037)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marco Montalbano <[email protected]>
Co-authored-by: Andreas Egger <[email protected]>
Co-authored-by: João Melo <[email protected]>
Co-authored-by: Patrick Edqvist <[email protected]>
Co-authored-by: Janko Marklein <[email protected]>
Co-authored-by: Andreas Egger <[email protected]>
Co-authored-by: Meike Pollakowski <[email protected]>
Co-authored-by: Meike P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants