feat: update Notification to support React 18 #2955
+16
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
The Notification package is currently broken when upgrading to React 19 (and somewhat breaks the use of React 18) because it uses the deprecated
render
function instead of the newercreateRoot()
method of mounting a component.I figured keeping support for previous React versions is desired so I added a conditional import to use this new method when running React 18 or higher.
PR Checklist
readme.md
file(s)