Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate configuration documentation from ci #1623

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Generate configuration documentation from ci #1623

merged 2 commits into from
Oct 22, 2024

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Oct 6, 2024 •
edited
Loading

Refs #1622

Adds reflection-cpp dependency and handles generation of global configuration part of the documentation

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Oct 6, 2024
@christianparpart christianparpart added the no changelog Tells the CI to not require a changelog entry label Oct 6, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/generate_config_info branch 2 times, most recently from 29503d5 to b4e4a18 Compare October 9, 2024 16:54
@github-actions github-actions bot added CMake documentation Improvements or additions to documentation CI GitHub Actions & CI labels Oct 18, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/generate_config_info branch from 4c89ab5 to d6b13e5 Compare October 18, 2024 09:29
@Yaraslaut Yaraslaut marked this pull request as ready for review October 18, 2024 09:29
@Yaraslaut Yaraslaut force-pushed the improvement/generate_config_info branch 4 times, most recently from 4b4acad to 154ced7 Compare October 18, 2024 12:54
@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Oct 18, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/generate_config_info branch 5 times, most recently from e819c9e to dc3fea7 Compare October 21, 2024 14:59
christianparpart
christianparpart previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments. Many thanks. :)

src/contour/CMakeLists.txt Outdated Show resolved Hide resolved
src/contour/ContourApp.cpp Show resolved Hide resolved
@christianparpart
Copy link
Member

p.s.: clang-tidy complains a lot about unused parameters in Config.cpp

@Yaraslaut Yaraslaut force-pushed the improvement/generate_config_info branch from dc3fea7 to 1ebb048 Compare October 22, 2024 06:50
@Yaraslaut Yaraslaut force-pushed the improvement/generate_config_info branch from 1ebb048 to db36b81 Compare October 22, 2024 07:17
@Yaraslaut Yaraslaut merged commit ba85243 into master Oct 22, 2024
32 checks passed
@Yaraslaut Yaraslaut deleted the improvement/generate_config_info branch October 22, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart left review comments

Assignees
No one assigned
Labels
CI GitHub Actions & CI CMake documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaraslaut @christianparpart