Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): replaced globby with glob #2370 #2952

Closed

Conversation

MadhaviMandalia
Copy link
Contributor

Description

  • Replaced globby version to glob in package.json

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Thanks for giving this a try!

Current status:
image
https://app.circleci.com/pipelines/github/conventional-changelog/commitlint/6332/workflows/1f3545a0-e863-4e6f-af0a-07f0f09c19fd/jobs/24378

The end result should be that all current tests are passing and linting works.

Try the following things:

  1. Do a yarn, after that also the yarn.lock`-file should be updated.
  2. Search for globby over the whole project and replace it with the new package
    i.e. places like this (and similar all other places):

@MadhaviMandalia
Copy link
Contributor Author

Ok thanks @escapedcat I will check and update.

@escapedcat
Copy link
Member

Later on please modify your commit to i.e.:
chore: replaced globby with glob #2370
Because this won't change the code, no need to use fix, feat or refactor. chore is fine.

You can change the commit by using i.e. git commit --amend and doing git push --force after.

@MadhaviMandalia
Copy link
Contributor Author

I don't think we should change this because that would call local function glob. Please let me know if there is any change.

https://github.com/MadhaviMandalia/commitlint/blob/35ca695ae49df71fa636171cba2547aefc4a7357/%40commitlint/rules/src/index.test.ts#L31

@escapedcat
Copy link
Member

I don't think we should change this because that would call local function glob. Please let me know if there is any change.

Yeah, not only the package is being switched, also the function has to be switched accordingly everywhere were currently globby is being used.
Have a look at how glob should be used: https://github.com/isaacs/node-glob#usage

@escapedcat
Copy link
Member

@MadhaviMandalia let me know if you need help with this

@escapedcat
Copy link
Member

Closing this for now. Might re-open when we continue.

@escapedcat escapedcat closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants