Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(load): use cosmiconfig-typescript-loader v5 to remove ts-node dependency #3722

Conversation

joberstein
Copy link
Contributor

Link to original PR: #3633

Just re-applying the changes.

@joberstein
Copy link
Contributor Author

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

@escapedcat
Copy link
Member

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

Thanks! Let me know when you think it can be merged.
This is not a breaking change for others, right? Just want to double check that.

@joberstein
Copy link
Contributor Author

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

Thanks! Let me know when you think it can be merged. This is not a breaking change for others, right? Just want to double check that.

It should not be breaking, now that node >= 16 is required, but I'll take another look at the changelog also.

@joberstein joberstein changed the base branch from master to renovate/tar-fs-3.x October 26, 2023 03:12
@joberstein joberstein changed the base branch from renovate/tar-fs-3.x to master October 26, 2023 03:12
@escapedcat
Copy link
Member

Changelog looks good. Will merge again :P

@escapedcat escapedcat merged commit 1ff49ea into conventional-changelog:master Oct 26, 2023
3 checks passed
@escapedcat
Copy link
Member

https://github.com/conventional-changelog/commitlint/releases/tag/v18.2.0

@joberstein
Copy link
Contributor Author

I didn't get a chance to test it out yesterday but I didn't see any other breaking changes yesterday (only additive like support for Esm).

I'll test it out today but it's pretty identical to the original.

@joberstein
Copy link
Contributor Author

@escapedcat seems like it's working well, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants