Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use conventional config when using zero configuration #600

Closed
wants to merge 1 commit into from

Conversation

byCedric
Copy link
Member

Description

Fixes #260

Motivation and Context

See #260

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

BREAKING CHANGE: consumers might depend on the "pass through" behaviour of unconfigured commitlint
@byCedric
Copy link
Member Author

It might be better if we create a new release before merging this, PR #597 could be implemented for 7.x.x.

@byCedric
Copy link
Member Author

Wait, I'm going to retry this but not in CLI. It's not working as I would expect it. I'm giving it another swing in the @commitlint/load package, since cosmiconfig will tell us there if there is any.

@byCedric byCedric closed this Mar 23, 2019
@escapedcat escapedcat deleted the feat/zero-config branch August 1, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Load config-conventional in absence of user configuration
1 participant