feat: append eol to package.json

[nexdrew]

Fixes #37.

I'm thinking we should probably replace all \n characters with os.EOL to be more Windows friendly. I separated the commits so I can easily revert the 2nd one if you disagree.

[coveralls]

Coverage increased (+0.06%) to 95.238% when pulling c63fb34 on nexdrew:eol into 013b145 on conventional-changelog:master.

[bcoe]

👍 no objection from me

[bcoe]

@nexdrew made you an owner of the npm package FYI.

[stevemao]

Would this cause inconsistent eol? Or we don't want to enforce it?

[nexdrew]

@stevemao Not sure I follow you. What do you mean by "inconsistent eol"? Do you mean changing it b/w Windows and *nix runs?

Do you think we should try to detect which eol the files have (like Atom) before rewriting/appending to them? That would probably be better.

[stevemao]

If i ran the command on windows and later on i run the same command on
linux, there would be a change because of different eol. Not sure if this
is expected?
On 22 May 2016 12:00 PM, "Andrew Goode" [email protected] wrote:

@stevemao https://github.com/stevemao Not sure I follow you. What do
you mean by "inconsistent eol"? Do you mean changing it b/w Windows and
*nix runs?

Do you think we should try to detect which eol the files have (like Atom)
before rewriting/appending to them? That would probably be better.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#38 (comment)

[nexdrew]

@stevemao Yeah, that's a good point. I'll change it to detect existing eol instead of always using the platform-specific one.

[coveralls]

Coverage increased (+0.3%) to 95.506% when pulling 38bcf34 on nexdrew:eol into 013b145 on conventional-changelog:master.

[nexdrew]

I seem to have opened a small can of worms here. It works as expected for package.json (though we might want to consider also using detect-indent to preserve indentation too) but I'm not too sure about CHANGELOG.md since conventional-changelog always uses \n (I think), which seems less important given that the content there should always be generated.

If you think this is too much, I'd be ok simplifying this to just append \n to package.json and splitting the EOL preservation into another PR. Definitely a little scope creep here.

[stevemao]

Well conventional-changelog uses templates so yeah it should be always \n. I never came across require('os').EOL before and I'm not sure about when to use it, when not to.

[nexdrew]

Closing in favor of #42 (fix without scope creep) and #43 (new issue to discuss problems encountered here).