Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit train w/ memory test but without setting any limit #2200

Closed
wants to merge 7 commits into from

Conversation

wasertech
Copy link
Collaborator

By setting limit to 0 for train_impl, we can keep the memory test without encountering #2195 making #2199 obsolete.

See the logs for the test: https://gist.github.com/wasertech/7274eee6e6d9a599920949788b248bbf

We need to fix this parameter so it doesn't prevent the exit of the process.

@reuben
Copy link
Collaborator

reuben commented Apr 26, 2022

limit=0 is equivalent to not doing any memory test at all. Instead, could you add a flag that disables the test so people have a workaround that doesn't require changing the code?

@wasertech
Copy link
Collaborator Author

@reuben checkout #2205. I'll close this PR and the others related for clarity.

@wasertech wasertech closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants