Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay import of WebDataset to prevent missing PyTorch issue on import #2230

Merged
merged 1 commit into from
May 30, 2022
Merged

Delay import of WebDataset to prevent missing PyTorch issue on import #2230

merged 1 commit into from
May 30, 2022

Conversation

reuben
Copy link
Collaborator

@reuben reuben commented May 30, 2022

No description provided.

@reuben reuben force-pushed the late-import-webdataset branch from f9bfe44 to e308677 Compare May 30, 2022 17:22
@wasertech
Copy link
Collaborator

Perfect!

@wasertech
Copy link
Collaborator

wasertech commented May 30, 2022 •
edited
Loading

It didn't install the training module in the venv. Logs here

My bad it's not merged ahah

@wasertech
Copy link
Collaborator

wasertech commented May 30, 2022 •
edited
Loading

LTGM!
I still don't know what to do with

  • reformatted bin/import_atthack.py
  • reformatted bin/import_ccpmf.py
  • reformatted bin/import_m-ailabs.py
  • reformatted training/coqui_stt_training/train.py
  • reformatted training/coqui_stt_training/util/config.py

The pre-hook skips black and if I do it manually it doesn't allow me to commit...

@reuben reuben merged commit 22ca7ba into main May 30, 2022
@reuben reuben deleted the late-import-webdataset branch May 30, 2022 18:09
@wasertech wasertech mentioned this pull request May 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reuben @wasertech