CVE-2007-4559 Patch

bin/import_aidatatang.py

@@ -12,7 +12,26 @@
 def extract(archive_path, target_dir):
     print("Extracting {} into {}...".format(archive_path, target_dir))
     with tarfile.open(archive_path) as tar:
-        tar.extractall(target_dir)
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, target_dir)
 
 
 def preprocess_data(tgz_file, target_dir):

bin/import_aishell.py

@@ -12,7 +12,26 @@
 def extract(archive_path, target_dir):
     print("Extracting {} into {}...".format(archive_path, target_dir))
     with tarfile.open(archive_path) as tar:
-        tar.extractall(target_dir)
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, target_dir)
 
 
 def preprocess_data(tgz_file, target_dir):

bin/import_cv.py

@@ -44,7 +44,26 @@ def _maybe_extract(target_dir, extracted_data, archive_path):
     if not os.path.exists(extracted_path):
         print('No directory "%s" - extracting archive...' % extracted_path)
         with tarfile.open(archive_path) as tar:
-            tar.extractall(target_dir)
+            def is_within_directory(directory, target):
+
+                abs_directory = os.path.abspath(directory)
+                abs_target = os.path.abspath(target)
+
+                prefix = os.path.commonprefix([abs_directory, abs_target])
+
+                return prefix == abs_directory
+
+            def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+                for member in tar.getmembers():
+                    member_path = os.path.join(path, member.name)
+                    if not is_within_directory(path, member_path):
+                        raise Exception("Attempted Path Traversal in Tar File")
+
+                tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+            safe_extract(tar, target_dir)
     else:
         print('Found directory "%s" - not extracting it from archive.' % extracted_path)
 

bin/import_freestmandarin.py

@@ -13,7 +13,26 @@
 def extract(archive_path, target_dir):
     print("Extracting {} into {}...".format(archive_path, target_dir))
     with tarfile.open(archive_path) as tar:
-        tar.extractall(target_dir)
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, target_dir)
 
 
 def preprocess_data(tgz_file, target_dir):

bin/import_magicdata.py

@@ -13,7 +13,26 @@
 def extract(archive_path, target_dir):
     print("Extracting {} into {}...".format(archive_path, target_dir))
     with tarfile.open(archive_path) as tar:
-        tar.extractall(target_dir)
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, target_dir)
 
 
 def is_file_truncated(wav_filename, wav_filesize):

bin/import_primewords.py

@@ -14,7 +14,26 @@
 def extract(archive_path, target_dir):
     print("Extracting {} into {}...".format(archive_path, target_dir))
     with tarfile.open(archive_path) as tar:
-        tar.extractall(target_dir)
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, target_dir)
 
 
 def preprocess_data(tgz_file, target_dir):

bin/import_swb.py

@@ -108,7 +108,26 @@ def _download_and_preprocess_data(data_dir):
 
 def _extract(target_dir, archive_path):
     with tarfile.open(archive_path) as tar:
-        tar.extractall(target_dir)
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, target_dir)
 
 
 def _maybe_convert_wav(data_dir, original_data, converted_data):