Feat: constants declared in impl blocks in seeds #2128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
As of now, constants declared in
impl
blocks, such as theimpl
block for anaccount
struct, are not parsed in the seeds constraint field.A common pattern I've used is to declare the
space
and the seeds constant for a specific PDA account as a constant impl of theaccount
struct. This PR fixes adds the necessary parsing to make this work.IDL behavior with this PR:
The above JSON was generated with the following constraints:
where CollectionPDA prefix is defined as below:
The changes in this PR only impact IDL generation with seeds, and don't touch any other logic.