idl: Disallow empty discriminators #3166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible to set the discriminators to an empty array. For example:
This shouldn't be allowed due to security and convenience reasons.
Summary of changes
Disallow empty discriminators during IDL generation.
The reason for handling this during IDL build process is because we can't reliably get the discriminator from parsing the input (e.g.
discriminator = EMPTY
is also valid).And the reason for not implementing our own custom discriminator type e.g.
is because it would not allow using programs that don't have discriminators (e.g. some of the SPL programs).
Note: This PR is part of a greater effort explained in #3097.