Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "tests/ingition/kdump: add a remote NFS kdump test" #3914

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dustymabe
Copy link
Member

This reverts commit b10d8dc.

The test passes on F40 but not on F41+ [1] and also it is failing on RHCOS so let's just yank it for now and re-apply when it's confirmed to be passing everywhere.

[1] coreos/fedora-coreos-tracker#1820

This reverts commit b10d8dc.

The test passes on F40 but not on F41+ [1] and also it is failing
on RHCOS so let's just yank it for now and re-apply when it's
confirmed to be passing everywhere.

[1] coreos/fedora-coreos-tracker#1820
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@c4rt0
Copy link
Member

c4rt0 commented Oct 25, 2024

Thanks for this @dustymabe.

@jbtrystram
Copy link
Contributor

😭

Copy link

openshift-ci bot commented Oct 25, 2024

@dustymabe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos 696dbaa link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustymabe
Copy link
Member Author

hmm the rhcos.upgrade.from-ocp-rhcos fail in prow/rhcos

but really removing this test couldn't cause that.. merging over red

@dustymabe dustymabe disabled auto-merge October 25, 2024 18:36
@dustymabe dustymabe merged commit af1468c into coreos:main Oct 25, 2024
4 of 5 checks passed
@dustymabe dustymabe deleted the dusty-revert branch October 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants