Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework live image docs #355

Merged
merged 15 commits into from
Feb 17, 2022
Merged

Rework live image docs #355

merged 15 commits into from
Feb 17, 2022

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Feb 11, 2022

Separate out bare-metal installation, live image quickstart instructions, and live image reference material into their own pages. Document live image customization and various other details. Do some cleanup.

Requires coreos/coreos-installer#776.

@bgilbert bgilbert linked an issue Feb 11, 2022 that may be closed by this pull request
@bgilbert bgilbert marked this pull request as draft February 11, 2022 09:33
This should be the default now.
@bgilbert bgilbert marked this pull request as ready for review February 11, 2022 22:27
It's more privileged than necessary.
We've required a rootfs artifact since October 2020, so stop describing
a two-artifact world.  While we're here, also spell out RAM requirements
for each case.

Also explicitly recommend coreos.live.rootfs_url over the other options.
It requires less RAM and avoids performance bottlenecks in the firmware's
network stack when fetching the rootfs.  See
coreos/fedora-coreos-tracker#1055.
@bgilbert bgilbert changed the title PXE improvements Rework live image docs Feb 13, 2022
@bgilbert
Copy link
Contributor Author

bgilbert commented Feb 13, 2022

Upstream docs update in coreos/coreos-installer#776.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great!

modules/ROOT/pages/live-booting-ipxe.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/live-reference.adoc Show resolved Hide resolved
modules/ROOT/pages/live-reference.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/live-booting.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/bare-metal.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/live-reference.adoc Show resolved Hide resolved
It's confusing to give live iPXE its own page but put live PXE in the
middle of the bare-metal instructions, since most of the docs are common
to both methods.
We might as well document an example iPXE install script, based on the
one in the live iPXE docs.
There are multiple live image tricks that need documenting, so give them
their own page.
modules/ROOT/nav.adoc Show resolved Hide resolved
modules/ROOT/pages/live-booting.adoc Outdated Show resolved Hide resolved
Stop conflating them with install docs.

Since live-booting-ipxe.adoc now contains PXE and ISO instructions as
well, rename it to live-booting.adoc, update the nav title, and add a
redirect.
Get rid of the manual configuration cruft.  De-emphasize the distinction
between live and dest Ignition configs, since users won't have to care
about that as much.

Fixes #245.
In particular, --copy-network isn't limited to the ISO/PXE environment,
but also works when running coreos-installer directly on bare metal.
@bgilbert
Copy link
Contributor Author

Updated!

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants