Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change coreos dracut configs file name convention #1837

Closed
daveyoung opened this issue Nov 20, 2024 · 6 comments · Fixed by coreos/fedora-coreos-config#3289
Closed

change coreos dracut configs file name convention #1837

daveyoung opened this issue Nov 20, 2024 · 6 comments · Fixed by coreos/fedora-coreos-config#3289
Labels
area/initramfs kind/enhancement status/pending-stable-release Fixed upstream and in testing. Waiting on stable release.

Comments

@daveyoung
Copy link

Describe the bug

As described in the #1729 the dracut config file name are not named with digit prefixes which are used more in other places eg. dracut default config files, or udev rules, or sysctl.d files. If CoreOS can use same convention these config files can be sourced in order. Then the #1729 #1832 can be solved all together since kdump will use itsown config dir with the new introduced --add-confdir option in dracut upstream.

Reproduction steps

Put a new config 90-test.conf in /etc/dracut.conf.d/ and we hope it will be sourced after any other config files with number prefixs less than 90.

Expected behavior

the config files are named with digit numbers

Actual behavior

the config files CoreOS added are not named with digt number prefixes.

System details

NA

Butane or Ignition config

No response

Additional information

No response
@daveyoung daveyoung mentioned this issue Nov 20, 2024
Open
@jbtrystram
Copy link
Contributor

I will be back at work on December 2nd and will gladly look into that if no one have started yet :)

@travier travier mentioned this issue Nov 27, 2024
Open
@travier
Copy link
Member

travier commented Nov 27, 2024

Sound like a good plan and could help solve:

jbtrystram added a commit to jbtrystram/fedora-coreos-config that referenced this issue Dec 2, 2024
@jbtrystram
overlay/dracut prefix dracut config files with number
3b41433 
Prefix our dracut configs with "60". This allow for other configs such
as kdump to override ours if necessary.
This will allow for the kdump initramfs to not ship our modules
(e.g. ignition) making kdump initramfs smaller.

Fixes coreos/fedora-coreos-tracker#1837
@jbtrystram jbtrystram mentioned this issue Dec 2, 2024
Merged
jlebon pushed a commit to coreos/fedora-coreos-config that referenced this issue Dec 2, 2024
@jbtrystram @jlebon
overlay/dracut prefix dracut config files with number
2629255 
Prefix our dracut configs with "60". This allow for other configs such
as kdump to override ours if necessary.
This will allow for the kdump initramfs to not ship our modules
(e.g. ignition) making kdump initramfs smaller.

Fixes coreos/fedora-coreos-tracker#1837
@travier travier added status/pending-testing-release Fixed upstream. Waiting on a testing release. and removed status/pending-action Needs action labels Dec 2, 2024
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Dec 4, 2024
@jbtrystram @aaradhak
overlay/dracut prefix dracut config files with number
a040998 
Prefix our dracut configs with "60". This allow for other configs such
as kdump to override ours if necessary.
This will allow for the kdump initramfs to not ship our modules
(e.g. ignition) making kdump initramfs smaller.

Fixes coreos/fedora-coreos-tracker#1837
@daveyoung
Copy link
Author

@jbtrystram Thanks for taking care of this!

@dustymabe
Copy link
Member

The fix for this went into next stream release 41.20241215.1.0. Please try out the new release and report issues.

@dustymabe
Copy link
Member

The fix for this went into testing stream release 41.20241215.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. labels Dec 19, 2024
@dustymabe dustymabe changed the title Dracut config file name convention change coreos dracut configs file name convention Dec 19, 2024
@marmijo
Copy link
Member

marmijo commented Jan 10, 2025

The fix for this went into stable stream release 41.20241215.3.0. Please try out the new release and report issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/initramfs kind/enhancement status/pending-stable-release Fixed upstream and in testing. Waiting on stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

overlay/dracut: prefix dracut config files with number jbtrystram/fedora-coreos-config
5 participants
@dustymabe @daveyoung @jbtrystram @marmijo @travier