ci: adapt to new buildroot image #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: coreos/coreos-ci-lib#66 |
jlebon
commented
Mar 25, 2021
.cci.jenkinsfile
Outdated
| withEnv(["XDG_CACHE_HOME=${env.WORKSPACE}/cache"]) { | ||
| stage("Build") { | ||
| shwrap("make") | ||
| shwrap("make install DESTDIR=install") |
There was a problem hiding this comment.
The DESTDIR=install bit and overlays: "install" bit below is kinda awkward. We can look at adding more sugar for this in the future.
There was a problem hiding this comment.
Yeah definitely, centralizing and standardizing this is IMO a lot of the goal.
cgwalters
approved these changes
Mar 25, 2021
.cci.jenkinsfile
Outdated
| withEnv(["XDG_CACHE_HOME=${env.WORKSPACE}/cache"]) { | ||
| stage("Build") { | ||
| shwrap("make") | ||
| shwrap("make install DESTDIR=install") |
There was a problem hiding this comment.
Yeah definitely, centralizing and standardizing this is IMO a lot of the goal.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 25, 2021
Matching coreos/ignition#1182 and discussion in coreos/fedora-coreos-tracker#764
jlebon
force-pushed
the
pr/ci-adapt
branch
2 times, most recently
from
1b506b6 to
c781533
Compare
We're moving away from a buildroot image based on cosa, so we need to do our build in a separate pod. This is more complex, but the upside is that it guarantees that we're always building in the same buildroot that was used to build all of FCOS' components.
|
OK cool, this works! ✔️ |
|
(This patch also makes a small improvement: it more correctly limits the "blackbox" stage to only run that test, whereas before it ran all of |
arithx
approved these changes
Mar 25, 2021
bgilbert
approved these changes
Mar 25, 2021
cgwalters
added a commit
to coreos/rpm-ostree
that referenced
this pull request
Mar 26, 2021
Matching coreos/ignition#1182 and discussion in coreos/fedora-coreos-tracker#764
jlebon
added a commit
to jlebon/ssh-key-dir
that referenced
this pull request
Mar 29, 2021
Similar to coreos/ignition#1182 as a result of coreos/fedora-coreos-config#740.
jlebon
added a commit
to jlebon/ssh-key-dir
that referenced
this pull request
Mar 29, 2021
Similar to coreos/ignition#1182 as a result of coreos/fedora-coreos-config#740. As a bonus, we now get a clear separate stage for building. Add a stage for running unit tests, but keep it commented out for now and we'll circle back to it when it's cleaner to do once we have: coreos/fedora-coreos-config#917 GitHub Actions covers unit tests anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're moving away from a buildroot image based on cosa, so we need to do
our build in a separate pod. This is more complex, but the upside is
that it guarantees that we're always building in the same buildroot that
was used to build all of FCOS' components.