session: return ReturnCode from reset() on failure

Callers of reset() will care about a ReturnCode::NetError, since this is
what is actually typically returned on success. The HSM reboots
immediately when reset() is called, meaning it vanishes out from under
the connector which dutifully returns a NetError. However, don't try to
be clever here in the library and let callers deal with it.

src/session.rs

@@ -104,16 +104,19 @@ impl Session {
         }
     }
 
+    /// Reset the device to factory settings and reboot.
+    ///
+    /// Note that since the device reboots when this function is called, this function is far more
+    /// likely to return a `ReturnCode::NetError` upon success, since it will vanish out from
+    /// underneath the connector. However, it is left to library consumers to decide whether or not
+    /// this is an acceptable result.
     pub fn reset(self) -> Result<(), Error> {
-        let rc = ReturnCode::from(unsafe {
+        match ReturnCode::from(unsafe {
             yubihsm_sys::yh_util_reset(self.this.load(Ordering::Relaxed))
-        });
-
-        if rc != ReturnCode::Success {
-            bail!("util_reset failed: {}", rc);
+        }) {
+            ReturnCode::Success => Ok(()),
+            rc => Err(rc.into()),
         }
-
-        Ok(())
     }
 
     pub fn list_objects(&self) -> ListObjectsQuery {