This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Miscellaneous small fixes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually we should just return ReturnCodes directly from most functions rather than formatted strings, and leave it up to the consumer what to do with the ReturnCode.
Callers of reset() will care about a ReturnCode::NetError, since this is what is actually typically returned on success. The HSM reboots immediately when reset() is called, meaning it vanishes out from under the connector which dutifully returns a NetError. However, don't try to be clever here in the library and let callers deal with it.
crawford
approved these changes
Apr 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most significant thing here is deriving
FailforReturnCode, which allows returning bare ReturnCodes. Eventually I'd like to move over to doing so for most functions which returnResults, and leave it up to the library consumer to appropriately handle variousReturnCodes.