vmcheck/misc-2: Make compatible with staged default #1438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First the pinning tests would try to pin a staged deployment, and some of the later tests here depend on a subtle way on the state of the system. It's tempting to do a `reset` before each one and reboot but this makes things work. There's some additional assertions here as I went through and was debugging. Prep for making staging the default.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 3, 2018
First the pinning tests would try to pin a staged deployment, and some of the later tests here depend on a subtle way on the state of the system. It's tempting to do a `reset` before each one and reboot but this makes things work. There's some additional assertions here as I went through and was debugging. Prep for making staging the default. Closes: #1438 Approved by: jlebon
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 3, 2018
First the pinning tests would try to pin a staged deployment, and some of the later tests here depend on a subtle way on the state of the system. It's tempting to do a `reset` before each one and reboot but this makes things work. There's some additional assertions here as I went through and was debugging. Prep for making staging the default. Closes: #1438 Approved by: jlebon
|
@rh-atomic-bot retry |
|
OK, tests are running for real this time! |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First the pinning tests would try to pin a staged deployment,
and some of the later tests here depend on a subtle way on the
state of the system. It's tempting to do a
resetbefore each oneand reboot but this makes things work.
There's some additional assertions here as I went through and
was debugging.
Prep for making staging the default.