Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop EOL Go version, bump linter, restrict workflow access to repo #28

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Drop EOL Go version, bump linter, restrict workflow access to repo #28

merged 4 commits into from
Jul 28, 2021

Conversation

bgilbert
Copy link
Contributor

F33, F34, and OCP 4.9 have Go 1.15 or higher.

cgwalters
cgwalters approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my imagination, they give "CI maintenance" gold medals in the Olympics, and you'd have won one.

@cgwalters
Copy link
Member

Aside, it looks like we had e.g. 1.14 as a gating check for merging, so I had to delete that manually too.

@cgwalters cgwalters merged commit cb2a42c into coreos:main Jul 28, 2021
@bgilbert bgilbert deleted the workflow branch July 29, 2021 00:43
@cgwalters cgwalters mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgilbert @cgwalters