Converted frontend worker to a service. #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Mar 11, 2020
Frontend worker is now started only after all Querier module dependencies are started. Previously, worker was started much earlier, long before Querier was ready to accept queries. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Thanks for review! Added changelog entry now. |
|
cc @cyriltovena this also affects Loki, which uses frontend worker directly. Post 0.7 as well. (I'll start working on Loki integration soon, but just so you know about it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The query frontend worker in the querier was previously (before this PR) started in the init function. The side effect was that it started pulling jobs from the queue before the queryable is ready. This means queries fail during the rollout, until the queryable is ready.
This PR changes that. Frontend worker is now a service, and it is only started after all Querier module dependencies are started. This includes queryable.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]