Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to configure the number of TCP connections per host for Cassandra. #2666

Merged
merged 5 commits into from
Jun 2, 2020

Conversation

tomwilkie
Copy link
Contributor

@tomwilkie tomwilkie commented May 31, 2020

Allow users to configure the number of TCP connections per host for Cassandra

This should increase the number of streams (concurrent Cassandra requests) available on the client side, and reduce the chance of getting "gocql: no hosts in pool" errors under load.

Also, use separate clients for reads and writes, to stop the two interferring.

@tomwilkie tomwilkie force-pushed the cassandra-connections branch from 91a7bb0 to 8143e13 Compare June 2, 2020 08:56
@tomwilkie tomwilkie requested a review from gouthamve June 2, 2020 08:58
Copy link
Contributor

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tom Wilkie <[email protected]>
@tomwilkie tomwilkie merged commit 1568a28 into master Jun 2, 2020
@tomwilkie tomwilkie deleted the cassandra-connections branch June 2, 2020 12:30
tomwilkie added a commit to grafana/cortex that referenced this pull request Jun 8, 2020
…assandra. (cortexproject#2666)

* Allow users to configure the number of TCP connections per host for Cassandra.

Signed-off-by: Tom Wilkie <[email protected]>

* Update docs.

Signed-off-by: Tom Wilkie <[email protected]>

* Use flagext.DefaultValues in Cassandra fixtures.

Signed-off-by: Tom Wilkie <[email protected]>

* Use separate sessions for reads and write in Cassandra.

Signed-off-by: Tom Wilkie <[email protected]>

* Add changelog entries.

Signed-off-by: Tom Wilkie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants