Skip to content

Commit

Permalink
add coverage completion marker regardless of unit test failure (knati…
Browse files Browse the repository at this point in the history
…ve#728)

Coverage completion marker is used in pre-submit workflow to find
most recent healthy post-submit coverage result as a basis for comparison.
We are adding the marker now regardless of unit test failure, to prevent
stale comparison baseline

knative#679
  • Loading branch information
steuhs authored and knative-prow-robot committed May 6, 2019
1 parent 72c1325 commit 68872ca
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tools/coverage/artifacts/profiling.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ func runProfiling(covTargets []string, localArts *LocalArtifacts) {
if errCmdOutput != nil {
log.Printf("Error running 'go test -coverprofile ': error='%v'; combined output='%s'\n",
errCmdOutput, output)
} else {
log.Printf("coverage profile created @ '%s'", localArts.ProfilePath())
covIo.CreateMarker(localArts.Directory(), CovProfileCompletionMarker)
}
}

log.Printf("coverage profile created @ '%s'", localArts.ProfilePath())
covIo.CreateMarker(localArts.Directory(), CovProfileCompletionMarker)

stdoutPath := localArts.CovStdoutPath()
stdoutFile, err := os.Create(stdoutPath)
Expand Down

0 comments on commit 68872ca

Please sign in to comment.