Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Babylon testnet 3 #4050

Merged
merged 17 commits into from
Mar 12, 2024
Merged

Conversation

SebastianElvis
Copy link
Contributor

@SebastianElvis SebastianElvis commented Mar 7, 2024

This PR adds Babylon testnet 3 metadata.

@reversesigh
Copy link
Collaborator

reversesigh commented Mar 7, 2024

You have a few options here:

Close this PR and simply update the correct information in the current babylontest folder in a new PR. As long as the original testnet is dead, this is acceptable until you reach mainnet.

Or assuming the original testnet is dead and you'd like to preserve the history, change the status of the original babylontestnet to killed and change its folder name to babylontestnet1 and rename the folder for the new chain to babylontestnet

@SebastianElvis
Copy link
Contributor Author

You have a few options here:

Close this PR and simply update the correct information in the current babylontest folder in a new PR. As long as the original testnet is dead, this is acceptable until you reach mainnet.

Or assuming the original testnet is dead and you'd like to preserve the history, change the status of the original babylontestnet to killed and change its folder name to babylontestnet1 and rename the folder for the new chain to babylontestnet

Hi, thanks for the feedback. I have chosen to go for the second option, where I changed the status of the original testnet to killed and renamed it to babylontestnet1. I kept the new testnet name as babylontestnet3 to reflect the testnet version number (have seen some other projects doing this e.g., celestiatestnet3). Lmk if this sounds good to you.

@reversesigh
Copy link
Collaborator

@SebastianElvis Thank you!!

I'll refer to @JeremyParish69 on keeping the new testnet named babylontestnet3, but I do think we are trying to establish a standard and some of those examples might be before that.

A few more things and I think it should be good to go- On the new chain chain.json file, after "chain_id": "bbn-test3" add the line "pre_fork_chain_name": "babylontestnet1". Also please remove the images folder from the previous testnet as it should only exist for the current chain.

@JeremyParish69
Copy link
Collaborator

JeremyParish69 commented Mar 9, 2024

The plan is to keep the unnumbered chain (so babylontestnet in this case) as the current/latest chain, and all the images would just stay in there--moving images around seems like a needless chore and we definitely don't want duplicate images.

We should archive the previous fork as the numbered chain_name (like bablyontestnet1, babylontestnet2, etc.) as they are created, while keeping babylontestnet as the current and latest.

Interfaces throughout cosmos will/should only be querying the unnumbered chainnames, so having babylontestnet3 as the latest will get it excluded from some tools and interfaces

@SebastianElvis
Copy link
Contributor Author

Thanks @reversesigh @JeremyParish69 for the clarifications, which totally make sense to me.

I have revised the PR to 1) rename the current testnet folder as babylontestnet, 2) add the pre_fork_chain_name entry, 3) remove the duplicated logo files, and 4) change the logo URLs accordingly.

Please feel free to take a look again

@JeremyParish69
Copy link
Collaborator

Looks good to me and passes checks. @reversesigh looks good to you?

@reversesigh reversesigh merged commit aa75d07 into cosmos:master Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.