We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If we examine this code, it does an unnecessary if err != nil check that then masks a suspicious nil error that was actually non-nil
If we just did return condition as a simple coding style, there wouldn't be any problems
return condition
/cc @elias-orijtech @tac0turtle @julienrbrt
The text was updated successfully, but these errors were encountered:
must be copy and paste https://github.com/cometbft/cometbft-db/blob/main/rocksdb.go#L140C13-L140C13
https://github.com/cometbft/cometbft-db/blob/main/rocksdb.go#L140C13-L140C13
Sorry, something went wrong.
fix: fix pedantic returns in Pebble
bdc1b1a
Removes pedantic returns that are non-idiomatic Go. Fixes cosmos#94
I've sent a fix in PR #95
fix: fix pedantic returns in Pebble (#95)
8a5e4f5
Removes pedantic returns that are non-idiomatic Go. Fixes #94
Successfully merging a pull request may close this issue.
If we examine this code, it does an unnecessary if err != nil check that then masks a suspicious nil error that was actually non-nil
If we just did
return condition
as a simple coding style, there wouldn't be any problems/cc @elias-orijtech @tac0turtle @julienrbrt
The text was updated successfully, but these errors were encountered: