[rosetta] implement balance tracking and redo tx construction (#8729)

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>

CHANGELOG.md

@@ -40,7 +40,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 * [\#8559](https://github.com/cosmos/cosmos-sdk/pull/8559) Added Protobuf compatible secp256r1 ECDSA signatures.
 * [\#8786](https://github.com/cosmos/cosmos-sdk/pull/8786) Enabled secp256r1 in x/auth.
-
+* (rosetta) [\#8729](https://github.com/cosmos/cosmos-sdk/pull/8729) Data API fully supports balance tracking. Construction API can now construct any message supported by the application.
 
 ### Client Breaking Changes
 

contrib/rosetta/configuration/bootstrap.json

@@ -1,7 +1,7 @@
 [
   {
     "account_identifier": {
-      "address":"cosmos158nkd0l9tyemv2crp579rmj8dg37qty8lzff88"
+      "address":"cosmos1ujtnemf6jmfm995j000qdry064n5lq854gfe3j"
     },
     "currency":{
       "symbol":"stake",

contrib/rosetta/configuration/data.sh

@@ -45,7 +45,7 @@ sleep 10
 
 # send transaction to deterministic address
 echo sending transaction with addr $addr
-simd tx bank send "$addr" cosmos1wjmt63j4fv9nqda92nsrp2jp2vsukcke4va3pt 100stake --yes --keyring-backend=test --broadcast-mode=block --chain-id=testing
+simd tx bank send "$addr" cosmos19g9cm8ymzchq2qkcdv3zgqtwayj9asv3hjv5u5 100stake --yes --keyring-backend=test --broadcast-mode=block --chain-id=testing
 
 sleep 10
 

contrib/rosetta/configuration/rosetta.json

@@ -25,7 +25,7 @@
     "constructor_dsl_file": "transfer.ros",
     "end_conditions": {
       "create_account": 1,
-      "transfer": 3
+      "transfer": 1
     }
   },
   "data": {

contrib/rosetta/configuration/run_tests.sh

@@ -2,16 +2,6 @@
 
 set -e
 
-addr="abcd"
-
-send_tx() {
-  echo '12345678' | simd tx bank send $addr "$1" "$2"
-}
-
-detect_account() {
-  line=$1
-}
-
 wait_for_rosetta() {
   timeout 30 sh -c 'until nc -z $0 $1; do sleep 1; done' rosetta 8080
 }
@@ -25,5 +15,3 @@ rosetta-cli check:data --configuration-file ./config/rosetta.json
 echo "checking construction API"
 rosetta-cli check:construction --configuration-file ./config/rosetta.json
 
-echo "checking staking API"
-rosetta-cli check:construction --configuration-file ./config/staking.json

contrib/rosetta/configuration/transfer.ros

@@ -26,7 +26,7 @@ request_funds(1){
     loaded_account = find_balance({
       "account_identifier": {{random_account.account_identifier}},
       "minimum_balance":{
-        "value": "100",
+        "value": "50",
         "currency": {{currency}}
       }
     });
@@ -57,6 +57,8 @@ transfer(3){
         "currency": {{currency}}
       }
     });
+    acc_identifier = {{sender.account_identifier}};
+    sender_address = {{acc_identifier.address}};
     // Set the recipient_amount as some value <= sender.balance-max_fee
     max_fee = "0";
     fee_amount = "1";
@@ -76,34 +78,28 @@ transfer(3){
       "create_probability": 50
     });
     transfer.confirmation_depth = "1";
+    recipient_account_identifier = {{recipient.account_identifier}};
+    recipient_address = {{recipient_account_identifier.address}};
     transfer.operations = [
       {
         "operation_identifier":{"index":0},
-        "type":"fee",
-        "account":{{sender.account_identifier}},
-        "amount":{
-          "value":{{fee_value}},
-          "currency":{{currency}}
-        }
-      },
-      {
-        "operation_identifier":{"index":1},
         "type":"cosmos.bank.v1beta1.MsgSend",
         "account":{{sender.account_identifier}},
-        "amount":{
-          "value":{{sender_amount}},
-          "currency":{{currency}}
-        }
-      },
-      {
-        "operation_identifier":{"index":2},
-        "type":"cosmos.bank.v1beta1.MsgSend",
-        "account":{{recipient.account_identifier}},
-        "amount":{
-          "value":{{recipient_amount}},
-          "currency":{{currency}}
+        "metadata": {
+          "amount": [
+            {
+              "amount": {{recipient_amount}},
+              "denom":  {{currency.symbol}}
+            }
+          ],
+          "from_address": {{sender_address}},
+           "to_address": {{recipient_address}}
         }
       }
     ];
+    transfer.preprocess_metadata = {
+        "gas_price": "1stake",
+        "gas_limit": 250000
+    };
   }
 }

go.mod

@@ -45,7 +45,7 @@ require (
 	github.com/spf13/viper v1.7.1
 	github.com/stretchr/testify v1.7.0
 	github.com/tendermint/btcd v0.1.1
-	github.com/tendermint/cosmos-rosetta-gateway v0.3.0-rc2
+	github.com/tendermint/cosmos-rosetta-gateway v0.3.0-rc2.0.20210304154332-87d6ca4410df
 	github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15
 	github.com/tendermint/go-amino v0.16.0
 	github.com/tendermint/tendermint v0.34.8

go.sum

@@ -660,8 +660,8 @@ github.com/tecbot/gorocksdb v0.0.0-20191217155057-f0fad39f321c h1:g+WoO5jjkqGAzH
 github.com/tecbot/gorocksdb v0.0.0-20191217155057-f0fad39f321c/go.mod h1:ahpPrc7HpcfEWDQRZEmnXMzHY03mLDYMCxeDzy46i+8=
 github.com/tendermint/btcd v0.1.1 h1:0VcxPfflS2zZ3RiOAHkBiFUcPvbtRj5O7zHmcJWHV7s=
 github.com/tendermint/btcd v0.1.1/go.mod h1:DC6/m53jtQzr/NFmMNEu0rxf18/ktVoVtMrnDD5pN+U=
-github.com/tendermint/cosmos-rosetta-gateway v0.3.0-rc2 h1:crekJuQ57yIBDuKd3/dMJ00ZvOHURuv9RGJSi2hWTW4=
-github.com/tendermint/cosmos-rosetta-gateway v0.3.0-rc2/go.mod h1:gBPw8WV2Erm4UGHlBRiM3zaEBst4bsuihmMCNQdgP/s=
+github.com/tendermint/cosmos-rosetta-gateway v0.3.0-rc2.0.20210304154332-87d6ca4410df h1:hoMLrOS4WyyMM+Y+iWdGu94o0zzp6Q43y7v89Q1/OIw=
+github.com/tendermint/cosmos-rosetta-gateway v0.3.0-rc2.0.20210304154332-87d6ca4410df/go.mod h1:gBPw8WV2Erm4UGHlBRiM3zaEBst4bsuihmMCNQdgP/s=
 github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15 h1:hqAk8riJvK4RMWx1aInLzndwxKalgi5rTqgfXxOxbEI=
 github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15/go.mod h1:z4YtwM70uOnk8h0pjJYlj3zdYwi9l03By6iAIF5j/Pk=
 github.com/tendermint/go-amino v0.16.0 h1:GyhmgQKvqF82e2oZeuMSp9JTN0N09emoSZlb2lyGa2E=