implement comments

CHANGELOG.md

@@ -50,7 +50,6 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### API Breaking Changes
 
-* (simapp) [#12270](https://github.com/cosmos/cosmos-sdk/pull/12270) Remove `invCheckPeriod uint` from `NewSimApp` constructor  as per migration of `x/crisis` to app wiring
 * (simapp) [#12270](https://github.com/cosmos/cosmos-sdk/pull/12270) Remove `invCheckPeriod uint` attribute from `SimApp` struct  as per migration of `x/crisis` to app wiring
 * (simapp) [#XXXXX](https://github.com/cosmos/cosmos-sdk/pull/XXXXX) Move `simapp.ConvertAddrsToValAddrs` and `simapp.CreateTestPubKeys ` to respectively `simtestutil.ConvertAddrsToValAddrs` and `simtestutil.CreateTestPubKeys` (`testutil/sims`)
 * (simapp) [#12312](https://github.com/cosmos/cosmos-sdk/pull/12312) Move `simapp.EmptyAppOptions` to `simtestutil.EmptyAppOptions` (`testutil/sims`)

simapp/app.go

@@ -202,7 +202,7 @@ func NewSimApp(
 ) *SimApp {
 	var (
 		appBuilder *runtime.AppBuilder
-		app        = &SimApp{}
+		app        *SimApp
 
 		// merge the app.yaml and the appOpts in one config
 		appConfig = depinject.Configs(AppConfig, depinject.Supply(appOpts))

simapp/test_helpers.go

@@ -3,9 +3,10 @@ package simapp
 import (
 	"context"
 	"encoding/json"
+	"testing"
+
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/server"
-	"testing"
 
 	"github.com/stretchr/testify/require"
 	abci "github.com/tendermint/tendermint/abci/types"
@@ -34,11 +35,10 @@ import (
 
 // SetupOptions defines arguments that are passed into `Simapp` constructor.
 type SetupOptions struct {
-	Logger         log.Logger
-	DB             *dbm.MemDB
-	InvCheckPeriod uint
-	EncConfig      params.EncodingConfig
-	AppOpts        types.AppOptions
+	Logger    log.Logger
+	DB        *dbm.MemDB
+	EncConfig params.EncodingConfig
+	AppOpts   types.AppOptions
 }
 
 func setup(withGenesis bool, invCheckPeriod uint) (*SimApp, GenesisState) {