Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MaxMetadataLength as a group keeper parameter #10972

Closed
3 of 4 tasks
blushi opened this issue Jan 19, 2022 · 0 comments · Fixed by #11034
Closed
3 of 4 tasks

Add MaxMetadataLength as a group keeper parameter #10972

blushi opened this issue Jan 19, 2022 · 0 comments · Fixed by #11034
Assignees
@likhita-809
Labels
C:x/group

Comments

@blushi
Copy link
Contributor

blushi commented Jan 19, 2022

Summary

Add MaxMetadataLength as a group keeper parameter.

Problem Definition

Currently in x/group, MaxMetadataLength that defines the maximum metadata length for bytes metadata in GroupInfo, GroupPolicyInfo, Member and Proposal and Vote, is just set as a constant (255 bytes). This should be more configurable.

Proposal

Add MaxMetadataLength as a group keeper parameter.
We can also turn the list of parameters for group NewKeeper into a struct.
If MaxMetadataLength is not provided, then just use the current default value (255 bytes).

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

cc/ @aaronc @nooomski @hxrts @cmwaters
@cmwaters cmwaters mentioned this issue Jan 19, 2022
Closed
4 tasks
@likhita-809 likhita-809 self-assigned this Jan 20, 2022
@likhita-809 likhita-809 mentioned this issue Jan 27, 2022
Merged
19 tasks
@likhita-809 likhita-809 moved this from Ready to In Progress in Cosmos SDK: Gov & Group WG Jan 27, 2022
@amaury1093 amaury1093 moved this from In Progress to In Review in Cosmos SDK: Gov & Group WG Feb 1, 2022
@mergify mergify bot closed this as completed in #11034 Feb 3, 2022
mergify bot pushed a commit that referenced this issue Feb 3, 2022
@likhita-809
feat: Add max metadata length as a group keeper parameter (#11034)
ee6bedc 
## Description

Closes: #10972 

Add MaxMetadataLength as a group keeper parameter.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Repository owner moved this from In Review to Done in Cosmos SDK: Gov & Group WG Feb 3, 2022
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
@likhita-809
feat: Add max metadata length as a group keeper parameter (cosmos#11034)
be9e31e 
## Description

Closes: cosmos#10972 

Add MaxMetadataLength as a group keeper parameter.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likhita-809 likhita-809

Labels
C:x/group
Projects
No open projects
Cosmos SDK: Gov & Group WG
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add max metadata length as a group keeper parameter cosmos/cosmos-sdk
2 participants
@blushi @likhita-809