Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Protobuf // Since comments for v0.46 #11047

Closed
4 tasks
amaury1093 opened this issue Jan 27, 2022 · 2 comments · Fixed by #11094
Closed
4 tasks

Fix Protobuf // Since comments for v0.46 #11047

amaury1093 opened this issue Jan 27, 2022 · 2 comments · Fixed by #11094
Assignees
@tac0turtle
Labels
C: Proto Proto definition and proto release T: Client UX

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Jan 27, 2022 •
edited
Loading

Problem Definition

Some protobuf // Since: comments are wrong, because of the v045 release.

ref: cosmos/ibc-go#763 (comment)

Proposal

  • All Since: cosmos-sdk 0.45 should be replaced with Since: cosmos-sdk 0.46, as v045 is not proto-breaking.
  • gov package should have a Since: cosmos-sdk 0.46
  • all Since: cosmos-sdk 0.43 inside gov v1beta2 should be removed.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added T: Client UX C: Proto Proto definition and proto release labels Jan 27, 2022
@amaury1093 amaury1093 added this to the v0.46 milestone Jan 27, 2022
@tac0turtle tac0turtle self-assigned this Feb 2, 2022
@tac0turtle tac0turtle moved this from Todo to In Progress in Cosmos SDK Maintenance Feb 2, 2022
@tac0turtle
Copy link
Member

gov should have a Since: cosmos-sdk 0.46

do you mean every message in gov v1beta2 should have this?

@tac0turtle tac0turtle mentioned this issue Feb 2, 2022
Merged
19 tasks
@amaury1093
Copy link
Contributor Author

No, we deicded to only do the package. See for example authz:

cosmos-sdk/proto/cosmos/authz/v1beta1/authz.proto

Line 1 in ab95455

// Since: cosmos-sdk 0.43

Repository owner moved this from In Progress to Done in Cosmos SDK Maintenance Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
C: Proto Proto definition and proto release T: Client UX
Projects
No open projects
Cosmos SDK Maintenance
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove & add since: cosmos/cosmos-sdk
2 participants
@amaury1093 @tac0turtle