Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove & add since: #11094

Merged
merged 6 commits into from
Feb 2, 2022
Merged

chore: remove & add since: #11094

merged 6 commits into from
Feb 2, 2022

Conversation

tac0turtle
Copy link
Member

Description

Closes: #11047

  • Remove since 0.43 from gov v1beta2
  • since: 0.45 -> since 0.46

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #11094 (881ecc3) into master (4e8172d) will decrease coverage by 0.05%.
The diff coverage is 54.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11094      +/-   ##
==========================================
- Coverage   65.86%   65.81%   -0.06%     
==========================================
  Files         677      644      -33     
  Lines       68324    66042    -2282     
==========================================
- Hits        45004    43463    -1541     
+ Misses      20612    20085     -527     
+ Partials     2708     2494     -214     
Impacted Files Coverage Δ
x/authz/authorization_grant.go 55.88% <ø> (+20.74%) ⬆️
x/authz/keeper/msg_server.go 0.00% <ø> (ø)
x/gov/keeper/grpc_query.go 58.12% <36.64%> (-14.90%) ⬇️
x/gov/simulation/operations.go 85.31% <75.00%> (-0.64%) ⬇️
x/authz/client/testutil/grpc.go 98.26% <100.00%> (ø)
x/authz/client/testutil/query.go 100.00% <100.00%> (ø)
x/authz/client/testutil/test_helpers.go 100.00% <100.00%> (ø)
x/authz/client/testutil/tx.go 98.22% <100.00%> (-0.01%) ⬇️
x/authz/keeper/keeper.go 67.24% <100.00%> (-0.22%) ⬇️
x/authz/simulation/genesis.go 93.75% <100.00%> (+0.20%) ⬆️
... and 41 more

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

proto/cosmos/gov/v1beta2/tx.proto Show resolved Hide resolved
proto/cosmos/tx/v1beta1/tx.proto Show resolved Hide resolved
@tac0turtle tac0turtle requested a review from amaury1093 February 2, 2022 15:50
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 2, 2022
@tac0turtle tac0turtle merged commit 894969b into master Feb 2, 2022
@tac0turtle tac0turtle deleted the 11047-since branch February 2, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Protobuf // Since comments for v0.46
2 participants