feegrant module documentation missing for FilterFeeAllowance type #11346
Labels
T:Docs
Changes and features related to documentation.
Comments
19 tasks
Repository owner
moved this from In Progress
to Done
in Cosmos SDK Maintenance
Mar 11, 2022
mergify bot
pushed a commit
that referenced
this issue
Mar 11, 2022
## Description Closes: #11346 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of Bug
I noticed the FeeAllowance types section is missing the FilteredFee Allowance type (for some reason the code made it into the snippet for Periodic Allowance but not into the actual docs):
https://docs.cosmos.network/v0.44/modules/feegrant/01_concepts.html#fee-allowance-types
Concepts | Cosmos SDK
it would be great if this is updated as Omniflix is using this now to offset ibc tx fee costs for relayer operators and we could write up something about it/link to the docs if the docs were updated
Version
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: