Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.work should be in .gitignore #13098

Closed
kocubinski opened this issue Aug 30, 2022 · 1 comment · Fixed by #13100
Closed

go.work should be in .gitignore #13098

kocubinski opened this issue Aug 30, 2022 · 1 comment · Fixed by #13100

Comments

@kocubinski
Copy link
Member

go.work should not be checked into source control. A committed go.work is a statement that the checked in source trees of every module mentioned therein are compatible in build and test phases, locally and in CI. This is not true. We assert that module versions are compatible, not the current state of the source tree.

@julienrbrt
Copy link
Member

julienrbrt commented Aug 30, 2022

I agree, this currently causes problems in where PR need to be larger only to satisfy the go.work (cf #12797).
I think disabling it in CI only (like we tried to do for keeping it #12951) is confusing.
The go.work is however very useful. We should make it easy for devs to use it (by having a go.work.example) and have an explanation that when two go modules are modified two PR needs to be created, for avoiding that replace land in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants