Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add go.work in gitignore #13100

Merged
merged 8 commits into from
Aug 30, 2022
Merged

build: add go.work in gitignore #13100

merged 8 commits into from
Aug 30, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #13098


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think having GOWORK=off in make test might be useful as the official way to test how CI will see things. If I want to run tests with my local setup I usually do go test ./... for each module

@julienrbrt
Copy link
Member Author

It makes sense, updated!

@kocubinski
Copy link
Member

Was this total reformat of CHANGELOG.md intentional?

@julienrbrt
Copy link
Member Author

Was this total reformat of CHANGELOG.md intentional?

Not at first 😅, but I left it as it should still conform to our markdownlint configuration: https://github.com/cosmos/cosmos-sdk/blob/main/.markdownlint.json#L3

@julienrbrt julienrbrt enabled auto-merge (squash) August 30, 2022 20:58
@julienrbrt julienrbrt merged commit 2c527d0 into main Aug 30, 2022
@julienrbrt julienrbrt deleted the julien/gowork branch August 30, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.work should be in .gitignore
3 participants