-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure action tags are added for all msg types #1406
Comments
We need this for launch, at least for |
To avoid adding action tags manually, we can add |
Meh not too big of a fan of defining Tags in multiple locations, I'd personally like to see them consolidated, but doesn't super matter |
alternatively, I think adding a name function to msgs is reasonable. The purpose would be just to avoid reflection here. With reflection, any name change for the message struct is a state breaking change. I like the idea of avoiding adding action tags manually. |
This is to facillitate ease of implementing #1406. (Tags for messages could then be added dynamically) Ultimately once we make the router support hiearchical routing, (#770) we can then remove the name field and just the parse info for tags from that. Until then, we can parse the tag name as `fmt.Sprintf("%s %s", msg.Type(), msg.Name())`
This is to facillitate ease of implementing #1406. (Tags for messages could then be added dynamically) Ultimately once we make the router support hiearchical routing, (#770) we can then remove the name field and just the parse info for tags from that. Until then, we can parse the tag name as `fmt.Sprintf("%s %s", msg.Type(), msg.Name())`
This allows users to search for particular types of transactions. Action tags don't yet exist in
x/bank
, and may also need to be added elsewhere.cc @gamarin2
The text was updated successfully, but these errors were encountered: