Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file keyring backend prompt duplication #5403

Closed
4 tasks
austinabell opened this issue Dec 12, 2019 · 5 comments
Closed
4 tasks

file keyring backend prompt duplication #5403

austinabell opened this issue Dec 12, 2019 · 5 comments
Assignees
Labels

Comments

@austinabell
Copy link
Contributor

Summary of Bug

In the gentx command, using the keyring backend flag to file, password prompt occurs three times (should only be one?)

Also a question with this if you don't mind, why does keys show ... now require a prompt, specifically when using file storage? Is this intended?

Version

0e28da2

Steps to Reproduce

Running gentx with --keyring-backend file flag should be sufficient.

🌲🌲  ~/development/github.com/chainsafe/ethermint (austin/cosmosupdate) 🌲  emintd gentx --name mykey --keyring-backend file
Enter keyring passphrase:
Enter keyring passphrase:
Enter keyring passphrase:
Genesis transaction written to "/Users/austinabell/.emintd/config/gentx/gentx-48e731666b994a183b0b6aff17869505f2af30f2.json"

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze
Copy link
Collaborator

@alessio

alessio pushed a commit that referenced this issue Dec 13, 2019
Workaround for #5403, users are still prompted for password twice.
@alessio
Copy link
Contributor

alessio commented Dec 13, 2019

@austinabell dixit:

Also a question with this if you don't mind, why does keys show ... now require a prompt, specifically when using file storage? Is this intended?

Yes, it is. All keys data is now stored securely in the keyring, which needs to be unlocked before before one can access keys. The file backend does not account for the concept of user's session, therefore you are prompoted for the password every time you access the keyring. OS's credential store backed implementation works differently.

@alessio alessio closed this as completed Dec 13, 2019
@alessio alessio reopened this Dec 13, 2019
fedekunze pushed a commit that referenced this issue Dec 17, 2019
…5406)

Workaround for #5403, users are still prompted for password twice.
xiangjianmeng pushed a commit to xiangjianmeng/cosmos-sdk that referenced this issue Dec 18, 2019
@alessio alessio self-assigned this Mar 10, 2020
@alessio alessio added the T: UX label Mar 10, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 5, 2020
@tac0turtle
Copy link
Member

@alessio was this completed? I vaguely recall it being fixed but will close anyways in favor of #5771

@alessio
Copy link
Contributor

alessio commented Jul 6, 2020

Unsure. It was half-fixed. Possibly #5865 has fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants