Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS handler to grpc-web #9467

Closed
4 tasks
aleem1314 opened this issue Jun 7, 2021 · 0 comments · Fixed by #9493
Closed
4 tasks

Add CORS handler to grpc-web #9467

aleem1314 opened this issue Jun 7, 2021 · 0 comments · Fixed by #9493
Assignees
@aleem1314
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Milestone
Feature Backlog

Comments

@aleem1314
Copy link
Contributor

Summary of Bug

Access to fetch at 'http://localhost:9091/cosmos.bank.v1beta1.Query/Params' from origin 'http://localhost:8081' has been blocked by CORS policy: Request header field x-grpc-web is not allowed by Access-Control-Allow-Headers in preflight response.

Version

0.43.0-beta1

Steps to Reproduce

1.Initialize and start chain using simd start --grpc-web.enable=true.
2. Connect to grpc client using grpc-web JS client.

Proposal

Cors should be enabled only with a --unsafe-enable-cors flag.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@aleem1314 aleem1314 added C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. Priority: Nice To Have labels Jun 7, 2021
@aleem1314 aleem1314 added this to the v0.43 milestone Jun 7, 2021
@amaury1093 amaury1093 modified the milestones: v0.43, Feature Backlog Jun 8, 2021
@aleem1314 aleem1314 self-assigned this Jun 9, 2021
@aleem1314 aleem1314 mentioned this issue Jun 10, 2021
Merged
19 tasks
@mergify mergify bot closed this as completed in #9493 Jun 16, 2021
mergify bot pushed a commit that referenced this issue Jun 16, 2021
@aleem1314
feat: grpc-web add CORS handler (#9493)
38d6702 
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: #9467 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleem1314 aleem1314

Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
None yet
Milestone
Feature Backlog
Development

Successfully merging a pull request may close this issue.

feat: grpc-web add CORS handler cosmos/cosmos-sdk
3 participants
@aaronc @amaury1093 @aleem1314