Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add group module grpc-gateway #10773

Merged
merged 9 commits into from
Dec 16, 2021
Merged

Conversation

amaury1093
Copy link
Contributor

Description

Closes: #10661


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 force-pushed the am/10661-group-grpc-gateway branch from b0b0f2c to ef91b9c Compare December 14, 2021 13:32
@github-actions github-actions bot removed the C:orm label Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #10773 (a931abc) into master (109bc94) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head a931abc differs from pull request most recent head b3deb34. Consider uploading reports for the commit b3deb34 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10773      +/-   ##
==========================================
+ Coverage   64.75%   64.87%   +0.12%     
==========================================
  Files         624      623       -1     
  Lines       60354    60371      +17     
==========================================
+ Hits        39083    39168      +85     
+ Misses      19037    18953      -84     
- Partials     2234     2250      +16     
Impacted Files Coverage Δ
x/staking/migrations/v045/store.go 50.00% <0.00%> (-50.00%) ⬇️
baseapp/options.go 61.11% <0.00%> (-0.93%) ⬇️
baseapp/abci.go 60.21% <0.00%> (-0.69%) ⬇️
store/types/store.go 64.70% <0.00%> (ø)
x/staking/keeper/delegation.go 72.66% <0.00%> (ø)
store/v2/multi/sub_store.go
store/v2/dbadapter/store.go
db/memdb/db.go
db/adapter.go
db/prefix/prefix.go
... and 32 more

@blushi blushi self-assigned this Dec 14, 2021
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the conflicts?

proto/cosmos/group/v1beta1/query.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Dec 16, 2021
@amaury1093
Copy link
Contributor Author

When I run go mod tidy in x/group, I have:

go mod tidy
go: downloading github.com/spf13/cobra v1.3.0
go mod tidy: error loading go 1.16 module graph: github.com/cosmos/[email protected] requires
	github.com/cosmos/cosmos-sdk/x/[email protected]: invalid version: unknown revision 000000000000

If reproducibility with go 1.16 is not needed:
	go mod tidy -compat=1.17
For other options, see:
	https://golang.org/doc/modules/pruning

It's weird it's still mentioning 0.44.0

@mergify mergify bot merged commit a3371e3 into master Dec 16, 2021
@mergify mergify bot deleted the am/10661-group-grpc-gateway branch December 16, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grpc-gateway to group module
4 participants