fix: create query context with requested block height #10827

yun-yeo · 2021-12-22T04:20:04Z

Description

Can we back port this to v0.44.x?

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

yun-yeo · 2021-12-22T04:21:21Z

client/query.go

-		Data: key,
+		Path:   path,
+		Data:   key,
+		Height: ctx.Height,


This line is to keep convention with grpc query

cosmos-sdk/client/grpc_query.go

Lines 75 to 79 in b67c4b3

abciReq := abci.RequestQuery{

Path: method,

Data: reqBz,

Height: ctx.Height,

}

alexanderbez

LGTM -- seems like we've always been having issues re requested heights being passed around. Very messy stuff :-/

alexanderbez · 2021-12-22T14:30:54Z

I'm not sure if this should be back-ported. Do you know @AmauryM ?

tac0turtle

this doesn't look breaking, id be up for back porting.

amaury1093

thanks! @YunSuk-Yeo could you update master, or give write access to your branch so that our bot can merge your PR?

…ext-with-block-height

…ub.com/terra-money/cosmos-sdk into create-query-context-with-block-height

## Description close #10826 Can we back port this to v0.44.x? --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f8b552b)

## Description close #10826 Can we back port this to v0.44.x? --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f8b552b) Co-authored-by: yys <[email protected]>

…osmos#10867) ## Description close cosmos#10826 Can we back port this to v0.44.x? --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f8b552b) Co-authored-by: yys <[email protected]>

* fix: recreate compat field, of null pubkeys in multisig (backport cosmos#10515) (cosmos#10871) * fix: recreate compat field, of null pubkeys in multisig (cosmos#10515)  Closes: cosmos#10042 Port cosmos#10275 to master. This is addressing a regression issue for the previously merged cosmos#10061. Changelog entry and tests included in the merged cosmos#10061. --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 3f3ca31) * fix conflicts, add changelog Co-authored-by: Mario Karagiorgas <[email protected]> Co-authored-by: Amaury M <[email protected]> * fix: create query context with requested block height (cosmos#10827) (cosmos#10867) ## Description close cosmos#10826 Can we back port this to v0.44.x? --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f8b552b) Co-authored-by: yys <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mario Karagiorgas <[email protected]> Co-authored-by: Amaury M <[email protected]> Co-authored-by: yys <[email protected]>

…osmos#10866) ## Description close cosmos#10826 Can we back port this to v0.44.x? --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f8b552b) Co-authored-by: yys <[email protected]>

create query context with block height

38c113e

yun-yeo requested review from aaronc and alexanderbez as code owners December 22, 2021 04:20

github-actions bot added the C:CLI label Dec 22, 2021

yun-yeo commented Dec 22, 2021

View reviewed changes

Merge branch 'master' into create-query-context-with-block-height

74917ef

yun-yeo changed the title ~~create query context with requested block height~~ fix: create query context with requested block height Dec 22, 2021

changelog

52e362f

alexanderbez approved these changes Dec 22, 2021

View reviewed changes

alexanderbez added the C:baseapp label Dec 22, 2021

tac0turtle approved these changes Dec 22, 2021

View reviewed changes

Merge branch 'master' into create-query-context-with-block-height

c042279

ValarDragon approved these changes Dec 29, 2021

View reviewed changes

amaury1093 added backport/0.44.x A:automerge Automatically merge PR once all prerequisites pass. labels Jan 3, 2022

amaury1093 approved these changes Jan 3, 2022

View reviewed changes

yun-yeo added 2 commits January 4, 2022 20:39

Merge remote-tracking branch 'upstream/master' into create-query-cont…

16d5aaa

…ext-with-block-height

Merge branch 'create-query-context-with-block-height' of https://gith…

6c7e98b

…ub.com/terra-money/cosmos-sdk into create-query-context-with-block-height

mergify bot merged commit f8b552b into cosmos:master Jan 4, 2022

mergify bot mentioned this pull request Jan 4, 2022

fix: create query context with requested block height (backport #10827) #10866

Merged

mergify bot mentioned this pull request Jan 4, 2022

fix: create query context with requested block height (backport #10827) #10867

Merged

yun-yeo deleted the create-query-context-with-block-height branch January 5, 2022 03:02

yun-yeo mentioned this pull request Feb 3, 2022

[BUG] Height param is not supported on private full nodes, but it works on public lcd.terra.dev endpoint terra-money/classic-core#668

Closed

faddat mentioned this pull request Feb 28, 2022

v0.45.x akash-network/cosmos-sdk#176

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: create query context with requested block height #10827

fix: create query context with requested block height #10827

yun-yeo commented Dec 22, 2021 •

edited

Loading

yun-yeo Dec 22, 2021 •

edited

Loading

alexanderbez left a comment

alexanderbez commented Dec 22, 2021

tac0turtle left a comment

amaury1093 left a comment

	abciReq := abci.RequestQuery{
	Path: method,
	Data: reqBz,
	Height: ctx.Height,
	}

fix: create query context with requested block height #10827

fix: create query context with requested block height #10827

Conversation

yun-yeo commented Dec 22, 2021 • edited Loading

Description

Author Checklist

Reviewers Checklist

yun-yeo Dec 22, 2021 • edited Loading

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez commented Dec 22, 2021

tac0turtle left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

yun-yeo commented Dec 22, 2021 •

edited

Loading

yun-yeo Dec 22, 2021 •

edited

Loading