-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade the Cosmos-SDK to Go 1.18 #11663
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11663 +/- ##
==========================================
- Coverage 65.84% 65.83% -0.01%
==========================================
Files 667 667
Lines 70374 70374
==========================================
- Hits 46336 46334 -2
+ Misses 21347 21345 -2
- Partials 2691 2695 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Julien Robert <[email protected]>
fix `go get` troubles
PS: The reason that I took the explicit versions out of the Dockerfiles is that if they are there, it is certain that:
By not specifying the versions explicitly, we will always use the latest Go and alpine |
@faddat there are two CI failures
|
I think it is super reasonable to mention: |
Description
This PR works towards the completion of the Go Workspaces issue #11450
It does the following:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change