-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: unify app wiring documentation #12340
Conversation
@@ -0,0 +1,5 @@ | |||
# App Wiring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be expanded? not sure it needs its own file, not entirely sure why it was added to the docs as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually added it in every PR, I thought it might help if you want to have an app with only specific modules. You tell me if not needed, we can use this PR to remove from everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong, but this is related to how testing will be done which will have its own documentation. Right now the spec describes module specific designs.
Would a user need to look at this file? trying to better understand when someone would look at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will be the content of these files, I guess, still can be defined. Maybe it should be under Building Modules
instead, I have not put much thought into it. I do think we should mention it in the documentation, as it shows what are the dependencies of a module (that's why I thought specs was a good place).
Description
Generalize the documentation of app wiring between modules.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change