-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Refactor Community Pool Token Mechanics #12831
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12831 +/- ##
==========================================
+ Coverage 56.28% 56.38% +0.10%
==========================================
Files 648 644 -4
Lines 55025 54759 -266
==========================================
- Hits 30969 30878 -91
+ Misses 21560 21391 -169
+ Partials 2496 2490 -6
|
So unfortunately, after this approach I realized how intertwined the x/distribution module and it's account is with the community pool, which is a "virtual" account. This makes me lead to believe that my revised approach is also not viable. Given, this I'm going to close the PR and instead do the following:
|
Description
This PR introduces the following changes to the way community pool tokens are managed:
MsgFundCommunityPool
MsgCommunityPoolSpend
, thatx/gov
can execute via a proposal to spend community pool fundsChangelog
MsgFundCommunityPool
CommunityPoolSpendProposal
FeePool
CommunityPoolSpendProposal
x/gov v1beta handlerCommunityPoolSpendProposal
simulationsTODO
BlockedModuleAccountsOverride
is defined and update itcloses: #12098
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change