fix: (cli) community pool spend proposal #12957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheeshp
changed the title
atheeshp
changed the title
Codecov Report
@@ Coverage Diff @@
## main #12957 +/- ##
==========================================
- Coverage 55.87% 55.58% -0.30%
==========================================
Files 646 652 +6
Lines 54895 55041 +146
==========================================
- Hits 30675 30592 -83
- Misses 21762 21980 +218
- Partials 2458 2469 +11
|
anilcse
reviewed
Aug 19, 2022
Comment on lines
+317
to
+319
| if amount.IsZero() { | ||
| return fmt.Errorf("invalid amount: %s", amount) | ||
| } |
There was a problem hiding this comment.
Should we check this inside ValidateBasic ?
|
closing this PR since it's not needed, ref: #12852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12900
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change